feat: Added the ability to click on elements using the data-test selector.#209
Open
dmitritarasov wants to merge 3 commits intopestphp:4.xfrom
Open
feat: Added the ability to click on elements using the data-test selector.#209dmitritarasov wants to merge 3 commits intopestphp:4.xfrom
dmitritarasov wants to merge 3 commits intopestphp:4.xfrom
Conversation
dmitritarasov
changed the title
Member
|
what's is the difference between this and |
Author
|
The current PHPDoc says 'link with text' which is misleading. Let's just update it to reflect the actual smart selector behavior. Then clickSelector() is not needed. Updated the PR — replaced the duplicate method with an improved PHPDoc for click() instead. Please take another look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new clickSelector() method to InteractsWithElements trait
Allows clicking on elements by directly passing a data-test selector string